diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2009-12-16 01:37:17 +0100 |
|---|---|---|
| committer | David Woodhouse <David.Woodhouse@intel.com> | 2009-12-16 04:26:33 +0100 |
| commit | 0a032a4df6dc4a82bcd1c401e57ee71825d30c14 (patch) | |
| tree | 84e55c3a9de0402bfb0064ebea588ff940ac5b80 /drivers/mtd | |
| parent | mtd: cfi_cmdset_0002, fix lock imbalance (diff) | |
| download | linux-0a032a4df6dc4a82bcd1c401e57ee71825d30c14.tar.xz linux-0a032a4df6dc4a82bcd1c401e57ee71825d30c14.zip | |
mtd: OneNAND: Fix test of unsigned in onenand_otp_walk()
mtd->writesize and len are unsigned so the test does not work.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/onenand/onenand_base.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index 3330ea06917c..f63b1db3ffb3 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd/onenand/onenand_base.c @@ -3165,10 +3165,10 @@ static int onenand_otp_walk(struct mtd_info *mtd, loff_t from, size_t len, /* Check User/Factory boundary */ if (mode == MTD_OTP_USER) { - if (((mtd->writesize * otp_pages) - (from + len)) < 0) + if (mtd->writesize * otp_pages < from + len) return 0; } else { - if (((mtd->writesize * otp_pages) - len) < 0) + if (mtd->writesize * otp_pages < len) return 0; } |