summaryrefslogtreecommitdiffstats
path: root/drivers/mtd
diff options
context:
space:
mode:
authorBrian Norris <computersforpeace@gmail.com>2014-07-22 04:08:13 +0200
committerBrian Norris <computersforpeace@gmail.com>2014-08-19 20:53:09 +0200
commit1cc8d8413327a684cd5e93cd52ececb0223bb40b (patch)
treec7d135bdbd80f8c84bfd29a0413f4d10ad1cfc6c /drivers/mtd
parentmtd: nand: fix integer widening problems (diff)
downloadlinux-1cc8d8413327a684cd5e93cd52ececb0223bb40b.tar.xz
linux-1cc8d8413327a684cd5e93cd52ececb0223bb40b.zip
mtd: terminate user-provided string
Noticed by Coverity as a potential security issue. Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'drivers/mtd')
-rw-r--r--drivers/mtd/mtdchar.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index a0f54e80670c..53563955931b 100644
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
@@ -549,6 +549,9 @@ static int mtdchar_blkpg_ioctl(struct mtd_info *mtd,
if (mtd_is_partition(mtd))
return -EINVAL;
+ /* Sanitize user input */
+ p.devname[BLKPG_DEVNAMELTH - 1] = '\0';
+
return mtd_add_partition(mtd, p.devname, p.start, p.length);
case BLKPG_DEL_PARTITION: