diff options
| author | Sascha Hauer <s.hauer@pengutronix.de> | 2019-10-23 11:58:12 +0200 |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2020-01-16 23:34:50 +0100 |
| commit | ef5aafb6e4e9942a28cd300bdcda21ce6cbaf045 (patch) | |
| tree | 66737f50cbef1ca65437b091e5a940d4ead3d0c3 /drivers/mtd | |
| parent | Linux 5.5-rc6 (diff) | |
| download | linux-ef5aafb6e4e9942a28cd300bdcda21ce6cbaf045.tar.xz linux-ef5aafb6e4e9942a28cd300bdcda21ce6cbaf045.zip | |
ubi: fastmap: Fix inverted logic in seen selfcheck
set_seen() sets the bit corresponding to the PEB number in the bitmap,
so when self_check_seen() wants to find PEBs that haven't been seen we
have to print the PEBs that have their bit cleared, not the ones which
have it set.
Fixes: 5d71afb00840 ("ubi: Use bitmaps in Fastmap self-check code")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/ubi/fastmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index 1c7be4eb3ba6..ac78e7a0e06a 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -64,7 +64,7 @@ static int self_check_seen(struct ubi_device *ubi, unsigned long *seen) return 0; for (pnum = 0; pnum < ubi->peb_count; pnum++) { - if (test_bit(pnum, seen) && ubi->lookuptbl[pnum]) { + if (!test_bit(pnum, seen) && ubi->lookuptbl[pnum]) { ubi_err(ubi, "self-check failed for PEB %d, fastmap didn't see it", pnum); ret = -EINVAL; } |