diff options
| author | Jiri Slaby <jslaby@suse.cz> | 2009-12-10 14:23:57 +0100 |
|---|---|---|
| committer | David Woodhouse <David.Woodhouse@intel.com> | 2009-12-10 14:33:53 +0100 |
| commit | caf0e8e028516253afce6e40c52f0c193a221f8a (patch) | |
| tree | a3cb81d5c9315bf0a028be6e257af2de1eb28d14 /drivers/mtd | |
| parent | Revert "mtd: move mxcnd_remove to .exit.text" (diff) | |
| download | linux-caf0e8e028516253afce6e40c52f0c193a221f8a.tar.xz linux-caf0e8e028516253afce6e40c52f0c193a221f8a.zip | |
mtd: cfi_cmdset_0002, fix lock imbalance
Stanse found a double unlock in get_chip. get_chip is called with
chip->mutex held and caller is responsible for unlocking it too.
Do not unlock the lock in get_chip on a fail path. This would mean
a double unlock.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/chips/cfi_cmdset_0002.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 1d49e18adbf6..f3600e8d5382 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -569,7 +569,6 @@ static int get_chip(struct map_info *map, struct flchip *chip, unsigned long adr if (time_after(jiffies, timeo)) { printk(KERN_ERR "Waiting for chip to be ready timed out.\n"); - spin_unlock(chip->mutex); return -EIO; } spin_unlock(chip->mutex); |