summaryrefslogtreecommitdiffstats
path: root/drivers/net/acenic.c
diff options
context:
space:
mode:
authorEric Sesterhenn <snakebyte@gmx.de>2006-01-20 21:32:56 +0100
committerJeff Garzik <jgarzik@pobox.com>2006-01-27 04:09:40 +0100
commit6f9d47220eb2d1b17a0a3ecaf1b564ff95b8393d (patch)
tree956eced6edc00738c1a4919f17e272e9db3d0fd9 /drivers/net/acenic.c
parent[PATCH] bonding: fix ->get_settings error checking (diff)
downloadlinux-6f9d47220eb2d1b17a0a3ecaf1b564ff95b8393d.tar.xz
linux-6f9d47220eb2d1b17a0a3ecaf1b564ff95b8393d.zip
[PATCH] acenic: fix checking of read_eeprom_byte() return values
tmp in ace_init is u32 thus rendering read_eeprom_byte() return values checks useless. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/net/acenic.c')
-rw-r--r--drivers/net/acenic.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/acenic.c b/drivers/net/acenic.c
index b8953de5664a..b508812e97ac 100644
--- a/drivers/net/acenic.c
+++ b/drivers/net/acenic.c
@@ -1002,6 +1002,8 @@ static int __devinit ace_init(struct net_device *dev)
mac1 = 0;
for(i = 0; i < 4; i++) {
+ int tmp;
+
mac1 = mac1 << 8;
tmp = read_eeprom_byte(dev, 0x8c+i);
if (tmp < 0) {
@@ -1012,6 +1014,8 @@ static int __devinit ace_init(struct net_device *dev)
}
mac2 = 0;
for(i = 4; i < 8; i++) {
+ int tmp;
+
mac2 = mac2 << 8;
tmp = read_eeprom_byte(dev, 0x8c+i);
if (tmp < 0) {