summaryrefslogtreecommitdiffstats
path: root/drivers/net/appletalk
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2015-02-18 20:47:30 +0100
committerDavid S. Miller <davem@davemloft.net>2015-02-20 22:23:27 +0100
commit15added6a5940454e225c09b78837514d35fcf70 (patch)
tree7478548c995683cb7616371cbabb83262b88c2c8 /drivers/net/appletalk
parentsock: sock_dequeue_err_skb() needs hard irq safety (diff)
downloadlinux-15added6a5940454e225c09b78837514d35fcf70.tar.xz
linux-15added6a5940454e225c09b78837514d35fcf70.zip
net: smc91x: improve neponset hack
The smc91x driver tries to support multiple platforms at compile time, but they are mutually exclusive at runtime, and not clearly defined. Trying to build for CONFIG_SA1100_ASSABET without CONFIG_ASSABET_NEPONSET results in this link error: drivers/built-in.o: In function `smc_drv_probe': :(.text+0x33310c): undefined reference to `neponset_ncr_frob' since the neponset_ncr_set function is not defined otherwise. Similarly, building for both CONFIG_SA1100_ASSABET and CONFIG_SA1100_PLEB results in a different build error: smsc/smc91x.c: In function 'smc_drv_probe': smsc/smc91x.c:2299:2: error: implicit declaration of function 'neponset_ncr_set' [-Werror=implicit-function-declaration] neponset_ncr_set(NCR_ENET_OSC_EN); ^ smsc/smc91x.c:2299:19: error: 'NCR_ENET_OSC_EN' undeclared (first use in this function) neponset_ncr_set(NCR_ENET_OSC_EN); ^ This is an attempt to fix the call site responsible for both errors, making sure we call the function exactly when the driver is actually trying to run on the assabet/neponset machine. With this patch, I no longer see randconfig build errors in this file. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/appletalk')
0 files changed, 0 insertions, 0 deletions