diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2021-10-12 16:27:57 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-10-13 19:03:59 +0200 |
| commit | 13b5ffa0e282f3d18e57735e37b8fed3a392872b (patch) | |
| tree | 52b0862e3d866825464e63775e5bcb65eb732f15 /drivers/net/appletalk | |
| parent | Merge branch 'net-use-dev_addr_set-in-hamradio-and-ip-tunnels' (diff) | |
| download | linux-13b5ffa0e282f3d18e57735e37b8fed3a392872b.tar.xz linux-13b5ffa0e282f3d18e57735e37b8fed3a392872b.zip | |
net: remove single-byte netdev->dev_addr writes
Make the drivers which use single-byte netdev addresses
(netdev->addr_len == 1) use the appropriate address setting
helpers.
arcnet copies from int variables and io reads a lot, so
add a helper for arcnet drivers to use.
Similar helper could be reused for phonet and appletalk
but there isn't any good central location where we could
put it, and netdevice.h is already very crowded.
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for HSI
Link: https://lore.kernel.org/r/20211012142757.4124842-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/appletalk')
| -rw-r--r-- | drivers/net/appletalk/cops.c | 2 | ||||
| -rw-r--r-- | drivers/net/appletalk/ltpc.c | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/drivers/net/appletalk/cops.c b/drivers/net/appletalk/cops.c index f0695d68c47e..97f254bdbb16 100644 --- a/drivers/net/appletalk/cops.c +++ b/drivers/net/appletalk/cops.c @@ -945,8 +945,8 @@ static int cops_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) dev->broadcast[0] = 0xFF; /* Set hardware address. */ - dev->dev_addr[0] = aa->s_node; dev->addr_len = 1; + dev_addr_set(dev, &aa->s_node); return 0; case SIOCGIFADDR: diff --git a/drivers/net/appletalk/ltpc.c b/drivers/net/appletalk/ltpc.c index 1f8925e75b3f..388d7b3bd4c2 100644 --- a/drivers/net/appletalk/ltpc.c +++ b/drivers/net/appletalk/ltpc.c @@ -846,9 +846,8 @@ static int ltpc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) set_30 (dev,ltflags); dev->broadcast[0] = 0xFF; - dev->dev_addr[0] = aa->s_node; - dev->addr_len=1; + dev_addr_set(dev, &aa->s_node); return 0; |