summaryrefslogtreecommitdiffstats
path: root/drivers/net/atl1e
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2009-06-12 02:23:24 +0200
committerDavid S. Miller <davem@davemloft.net>2009-06-12 02:23:24 +0200
commit17d0cdfa8f3c09a110061c67421d662b3e149d0a (patch)
tree5e707b8787db0a8571b983a6c8c1d7bf88579788 /drivers/net/atl1e
parentMerge branch 'linux-2.6.31.y' of git://git.kernel.org/pub/scm/linux/kernel/gi... (diff)
downloadlinux-17d0cdfa8f3c09a110061c67421d662b3e149d0a.tar.xz
linux-17d0cdfa8f3c09a110061c67421d662b3e149d0a.zip
net: ntohs() misuse
Some drivers incorrectly use ntohs() instead of htons() A cleanup as htons() returns same result than ntohs(), but better to use the proper one. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/atl1e')
-rw-r--r--drivers/net/atl1e/atl1e_main.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/atl1e/atl1e_main.c b/drivers/net/atl1e/atl1e_main.c
index e1ae10cf30c1..9fc6d6d9060e 100644
--- a/drivers/net/atl1e/atl1e_main.c
+++ b/drivers/net/atl1e/atl1e_main.c
@@ -1602,7 +1602,7 @@ static u16 atl1e_cal_tdp_req(const struct sk_buff *skb)
}
if (skb_is_gso(skb)) {
- if (skb->protocol == ntohs(ETH_P_IP) ||
+ if (skb->protocol == htons(ETH_P_IP) ||
(skb_shinfo(skb)->gso_type == SKB_GSO_TCPV6)) {
proto_hdr_len = skb_transport_offset(skb) +
tcp_hdrlen(skb);
@@ -1878,7 +1878,7 @@ static int atl1e_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
TPD_VLAN_SHIFT;
}
- if (skb->protocol == ntohs(ETH_P_8021Q))
+ if (skb->protocol == htons(ETH_P_8021Q))
tpd->word3 |= 1 << TPD_VL_TAGGED_SHIFT;
if (skb_network_offset(skb) != ETH_HLEN)