diff options
| author | Jean Sacren <sakiwit@gmail.com> | 2021-10-28 20:24:53 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-10-29 14:41:28 +0200 |
| commit | 5bd663212f2e455f87368cc3a51bee72411499f4 (patch) | |
| tree | 91bfd8c9497447fd1b1370d9d19900e7c1a0d83a /drivers/net/bareudp.c | |
| parent | net: netxen: fix code indentation (diff) | |
| download | linux-5bd663212f2e455f87368cc3a51bee72411499f4.tar.xz linux-5bd663212f2e455f87368cc3a51bee72411499f4.zip | |
net: bareudp: fix duplicate checks of data[] expressions
Both !data[IFLA_BAREUDP_PORT] and !data[IFLA_BAREUDP_ETHERTYPE] are
checked. We should remove the checks of data[IFLA_BAREUDP_PORT] and
data[IFLA_BAREUDP_ETHERTYPE] that follow since they are always true.
Put both statements together in group and balance the space on both
sides of '=' sign.
Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bareudp.c')
| -rw-r--r-- | drivers/net/bareudp.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index 54e321a695ce..edffc3489a12 100644 --- a/drivers/net/bareudp.c +++ b/drivers/net/bareudp.c @@ -577,11 +577,8 @@ static int bareudp2info(struct nlattr *data[], struct bareudp_conf *conf, return -EINVAL; } - if (data[IFLA_BAREUDP_PORT]) - conf->port = nla_get_u16(data[IFLA_BAREUDP_PORT]); - - if (data[IFLA_BAREUDP_ETHERTYPE]) - conf->ethertype = nla_get_u16(data[IFLA_BAREUDP_ETHERTYPE]); + conf->port = nla_get_u16(data[IFLA_BAREUDP_PORT]); + conf->ethertype = nla_get_u16(data[IFLA_BAREUDP_ETHERTYPE]); if (data[IFLA_BAREUDP_SRCPORT_MIN]) conf->sport_min = nla_get_u16(data[IFLA_BAREUDP_SRCPORT_MIN]); |