diff options
| author | Ajit Khaparde <ajit.khaparde@emulex.com> | 2011-02-20 12:41:20 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-02-22 19:26:45 +0100 |
| commit | 4ee772144f376ddf2a8c6ea5708a1362a9e85002 (patch) | |
| tree | b30e524d5de14dbe98e1dacc853100d8b84d297d /drivers/net/benet/be_ethtool.c | |
| parent | be2net: add new counters to display via ethtool stats (diff) | |
| download | linux-4ee772144f376ddf2a8c6ea5708a1362a9e85002.tar.xz linux-4ee772144f376ddf2a8c6ea5708a1362a9e85002.zip | |
be2net: fixes in ethtool selftest
> add missing separator between items in ethtool self_test array
> fix reporting of test resluts when link is down and
when selftest command fails.
From: Suresh R <suresh.reddy@emulex.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/benet/be_ethtool.c')
| -rw-r--r-- | drivers/net/benet/be_ethtool.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c index 82a9a27a9812..0833cbdb9b53 100644 --- a/drivers/net/benet/be_ethtool.c +++ b/drivers/net/benet/be_ethtool.c @@ -127,7 +127,7 @@ static const char et_self_tests[][ETH_GSTRING_LEN] = { "MAC Loopback test", "PHY Loopback test", "External Loopback test", - "DDR DMA test" + "DDR DMA test", "Link test" }; @@ -642,7 +642,8 @@ be_self_test(struct net_device *netdev, struct ethtool_test *test, u64 *data) &qos_link_speed) != 0) { test->flags |= ETH_TEST_FL_FAILED; data[4] = -1; - } else if (mac_speed) { + } else if (!mac_speed) { + test->flags |= ETH_TEST_FL_FAILED; data[4] = 1; } } |