diff options
| author | Jarek Poplawski <jarkao2@gmail.com> | 2010-09-02 22:22:11 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-09-02 22:22:11 +0200 |
| commit | 0b5d404e349c0236b11466c0a4785520c0be6982 (patch) | |
| tree | f4e51049b1433982591204dd67d158ee84808ace /drivers/net/benet/be_hw.h | |
| parent | ipvs: avoid oops for passive FTP (diff) | |
| download | linux-0b5d404e349c0236b11466c0a4785520c0be6982.tar.xz linux-0b5d404e349c0236b11466c0a4785520c0be6982.zip | |
pkt_sched: Fix lockdep warning on est_tree_lock in gen_estimator
This patch fixes a lockdep warning:
[ 516.287584] =========================================================
[ 516.288386] [ INFO: possible irq lock inversion dependency detected ]
[ 516.288386] 2.6.35b #7
[ 516.288386] ---------------------------------------------------------
[ 516.288386] swapper/0 just changed the state of lock:
[ 516.288386] (&qdisc_tx_lock){+.-...}, at: [<c12eacda>] est_timer+0x62/0x1b4
[ 516.288386] but this lock took another, SOFTIRQ-unsafe lock in the past:
[ 516.288386] (est_tree_lock){+.+...}
[ 516.288386]
[ 516.288386] and interrupts could create inverse lock ordering between them.
...
So, est_tree_lock needs BH protection because it's taken by
qdisc_tx_lock, which is used both in BH and process contexts.
(Full warning with this patch at netdev, 02 Sep 2010.)
Fixes commit: ae638c47dc040b8def16d05dc6acdd527628f231
("pkt_sched: gen_estimator: add a new lock")
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/benet/be_hw.h')
0 files changed, 0 insertions, 0 deletions