diff options
| author | Jesse Gross <jesse@nicira.com> | 2010-10-21 13:30:43 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-10-22 04:59:32 +0200 |
| commit | ec37a48d1d16c30b655ac5280209edf52a6775d4 (patch) | |
| tree | de483247d7febde004678ef5f7ee2806b2ba90df /drivers/net/bnx2x/bnx2x_ethtool.c | |
| parent | vlan: Calling vlan_hwaccel_do_receive() is always valid. (diff) | |
| download | linux-ec37a48d1d16c30b655ac5280209edf52a6775d4.tar.xz linux-ec37a48d1d16c30b655ac5280209edf52a6775d4.zip | |
bnx2/bnx2x: Unsupported Ethtool operations should return -EINVAL.
Some cards don't support changing vlan offloading settings. Make
Ethtool set_flags return -EINVAL in those cases.
Reported-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bnx2x/bnx2x_ethtool.c')
| -rw-r--r-- | drivers/net/bnx2x/bnx2x_ethtool.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/bnx2x/bnx2x_ethtool.c b/drivers/net/bnx2x/bnx2x_ethtool.c index daefef618ef7..d02ffbdc9f0e 100644 --- a/drivers/net/bnx2x/bnx2x_ethtool.c +++ b/drivers/net/bnx2x/bnx2x_ethtool.c @@ -1123,7 +1123,7 @@ static int bnx2x_set_flags(struct net_device *dev, u32 data) } if (!(data & ETH_FLAG_RXVLAN)) - return -EOPNOTSUPP; + return -EINVAL; if ((data & ETH_FLAG_LRO) && bp->rx_csum && bp->disable_tpa) return -EINVAL; |