diff options
author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2020-05-10 18:37:40 +0200 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2020-05-11 04:52:33 +0200 |
commit | 9eb8eff0cf2f1e1afc0756bb30cb9746ba90dd07 (patch) | |
tree | 6b41633b856834a8cc2a05bdfde065475b19f702 /drivers/net/dsa/mv88e6xxx | |
parent | Merge branch 'net-hns3-misc-updates-for-next' (diff) | |
download | linux-9eb8eff0cf2f1e1afc0756bb30cb9746ba90dd07.tar.xz linux-9eb8eff0cf2f1e1afc0756bb30cb9746ba90dd07.zip |
net: bridge: allow enslaving some DSA master network devices
Commit 8db0a2ee2c63 ("net: bridge: reject DSA-enabled master netdevices
as bridge members") added a special check in br_if.c in order to check
for a DSA master network device with a tagging protocol configured. This
was done because back then, such devices, once enslaved in a bridge
would become inoperative and would not pass DSA tagged traffic anymore
due to br_handle_frame returning RX_HANDLER_CONSUMED.
But right now we have valid use cases which do require bridging of DSA
masters. One such example is when the DSA master ports are DSA switch
ports themselves (in a disjoint tree setup). This should be completely
equivalent, functionally speaking, from having multiple DSA switches
hanging off of the ports of a switchdev driver. So we should allow the
enslaving of DSA tagged master network devices.
Instead of the regular br_handle_frame(), install a new function
br_handle_frame_dummy() on these DSA masters, which returns
RX_HANDLER_PASS in order to call into the DSA specific tagging protocol
handlers, and lift the restriction from br_add_if.
Suggested-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/dsa/mv88e6xxx')
0 files changed, 0 insertions, 0 deletions