diff options
| author | Christian Marangi <ansuelsmth@gmail.com> | 2022-09-04 23:53:19 +0200 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2022-09-06 11:18:15 +0200 |
| commit | 42b998d4aa59b9dea51665e4f3be1d733c47e2bf (patch) | |
| tree | 6a932db3753eabeb760776f701f48c0772f6d5e3 /drivers/net/dsa/qca | |
| parent | tcp: fix early ETIMEDOUT after spurious non-SACK RTO (diff) | |
| download | linux-42b998d4aa59b9dea51665e4f3be1d733c47e2bf.tar.xz linux-42b998d4aa59b9dea51665e4f3be1d733c47e2bf.zip | |
net: dsa: qca8k: fix NULL pointer dereference for of_device_get_match_data
of_device_get_match_data is called on priv->dev before priv->dev is
actually set. Move of_device_get_match_data after priv->dev is correctly
set to fix this kernel panic.
Fixes: 3bb0844e7bcd ("net: dsa: qca8k: cache match data to speed up access")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20220904215319.13070-1-ansuelsmth@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/dsa/qca')
| -rw-r--r-- | drivers/net/dsa/qca/qca8k-8xxx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c index 1d3e7782a71f..c181346388a4 100644 --- a/drivers/net/dsa/qca/qca8k-8xxx.c +++ b/drivers/net/dsa/qca/qca8k-8xxx.c @@ -1889,9 +1889,9 @@ qca8k_sw_probe(struct mdio_device *mdiodev) if (!priv) return -ENOMEM; - priv->info = of_device_get_match_data(priv->dev); priv->bus = mdiodev->bus; priv->dev = &mdiodev->dev; + priv->info = of_device_get_match_data(priv->dev); priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset", GPIOD_ASIS); |