diff options
| author | Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2023-07-10 03:39:07 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-07-10 09:21:53 +0200 |
| commit | 87355b7c3da9bfd81935caba0ab763355147f7b0 (patch) | |
| tree | b5f683ae9391ab6ec7142bb47a1009f9f681d7a6 /drivers/net/dsa | |
| parent | net: lan743x: select FIXED_PHY (diff) | |
| download | linux-87355b7c3da9bfd81935caba0ab763355147f7b0.tar.xz linux-87355b7c3da9bfd81935caba0ab763355147f7b0.zip | |
net: dsa: qca8k: Add check for skb_copy
Add check for the return value of skb_copy in order to avoid NULL pointer
dereference.
Fixes: 2cd548566384 ("net: dsa: qca8k: add support for phy read/write with mgmt Ethernet")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/qca/qca8k-8xxx.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c index f7d7cfb2fd86..09b80644c11b 100644 --- a/drivers/net/dsa/qca/qca8k-8xxx.c +++ b/drivers/net/dsa/qca/qca8k-8xxx.c @@ -588,6 +588,9 @@ qca8k_phy_eth_busy_wait(struct qca8k_mgmt_eth_data *mgmt_eth_data, bool ack; int ret; + if (!skb) + return -ENOMEM; + reinit_completion(&mgmt_eth_data->rw_done); /* Increment seq_num and set it in the copy pkt */ |