diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-27 05:51:06 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-27 06:24:23 +0200 |
| commit | d8ad2f31f88d609e0f8e4a34f6aeeb482ee5423b (patch) | |
| tree | a187ab13b2616cb9a62b458e9a409d8ddf9b363b /drivers/net/ethernet/adaptec/starfire.c | |
| parent | isdn: hisax: config: Replace GFP_ATOMIC with GFP_KERNEL (diff) | |
| download | linux-d8ad2f31f88d609e0f8e4a34f6aeeb482ee5423b.tar.xz linux-d8ad2f31f88d609e0f8e4a34f6aeeb482ee5423b.zip | |
net: adaptec: Replace mdelay() with msleep() in starfire_init_one()
starfire_init_one() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/adaptec/starfire.c')
| -rw-r--r-- | drivers/net/ethernet/adaptec/starfire.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/adaptec/starfire.c b/drivers/net/ethernet/adaptec/starfire.c index 3872ab96b80a..097467f44b0d 100644 --- a/drivers/net/ethernet/adaptec/starfire.c +++ b/drivers/net/ethernet/adaptec/starfire.c @@ -802,7 +802,7 @@ static int starfire_init_one(struct pci_dev *pdev, int mii_status; for (phy = 0; phy < 32 && phy_idx < PHY_CNT; phy++) { mdio_write(dev, phy, MII_BMCR, BMCR_RESET); - mdelay(100); + msleep(100); boguscnt = 1000; while (--boguscnt > 0) if ((mdio_read(dev, phy, MII_BMCR) & BMCR_RESET) == 0) |