diff options
| author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2015-04-25 03:07:03 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-04-26 22:05:49 +0200 |
| commit | 0e03fd3e335d272bee88fe733d5fd13f5c5b7140 (patch) | |
| tree | 5868379cbbf23f5d453a25d102455f1329ace3f7 /drivers/net/ethernet/altera | |
| parent | net: fix crash in build_skb() (diff) | |
| download | linux-0e03fd3e335d272bee88fe733d5fd13f5c5b7140.tar.xz linux-0e03fd3e335d272bee88fe733d5fd13f5c5b7140.zip | |
pxa168: fix double deallocation of managed resources
Commit 43d3ddf87a57 ("net: pxa168_eth: add device tree support") starts
to use managed resources by adding devm_clk_get() and
devm_ioremap_resource(), but it leaves explicit iounmap() and clock_put()
in pxa168_eth_remove() and in failure handling code of pxa168_eth_probe().
As a result double free can happen.
The patch removes explicit resource deallocation. Also it converts
clk_disable() to clk_disable_unprepare() to make it symmetrical with
clk_prepare_enable().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/altera')
0 files changed, 0 insertions, 0 deletions