diff options
| author | Pavel Belous <pavel.belous@aquantia.com> | 2017-02-20 20:36:46 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-02-20 23:11:09 +0100 |
| commit | df9000ef9609c8a5e57783d0667ba7f39f52ed1e (patch) | |
| tree | 3577f23d8ce2925166c9b48538f9bee8bc773271 /drivers/net/ethernet/aquantia/atlantic | |
| parent | net: ethernet: aquantia: Using NETDEV_TX_OK instead 0. (diff) | |
| download | linux-df9000ef9609c8a5e57783d0667ba7f39f52ed1e.tar.xz linux-df9000ef9609c8a5e57783d0667ba7f39f52ed1e.zip | |
net: ethernet: aquantia: Null pointer check for aq_nic_ndev_alloc.
We should check for a null pointer for aq_nic_ndev_alloc
instead netdev_priv.
Signed-off-by: Pavel Belous <pavel.belous@aquantia.com>
Reviewed-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/aquantia/atlantic')
| -rw-r--r-- | drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index 019bcc725715..a8a27c5e8aeb 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -202,12 +202,13 @@ struct aq_nic_s *aq_nic_alloc_cold(const struct net_device_ops *ndev_ops, int err = 0; ndev = aq_nic_ndev_alloc(); - self = netdev_priv(ndev); - if (!self) { - err = -EINVAL; + if (!ndev) { + err = -ENOMEM; goto err_exit; } + self = netdev_priv(ndev); + ndev->netdev_ops = ndev_ops; ndev->ethtool_ops = et_ops; |