diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2018-10-12 00:06:33 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-10-16 07:10:21 +0200 |
| commit | 64bd9c8135751b561f27edaaffe93d07093f81af (patch) | |
| tree | 63c938edeb3043479e7ab3b3d0b416345534a45a /drivers/net/ethernet/broadcom | |
| parent | rxrpc: use correct kvec num when sending BUSY response packet (diff) | |
| download | linux-64bd9c8135751b561f27edaaffe93d07093f81af.tar.xz linux-64bd9c8135751b561f27edaaffe93d07093f81af.zip | |
net: bcmgenet: Poll internal PHY for GENETv5
On GENETv5, there is a hardware issue which prevents the GENET hardware
from generating a link UP interrupt when the link is operating at
10Mbits/sec. Since we do not have any way to configure the link
detection logic, fallback to polling in that case.
Fixes: 421380856d9c ("net: bcmgenet: add support for the GENETv5 hardware")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom')
| -rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmmii.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index 4241ae928d4a..34af5f1569c8 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -321,9 +321,12 @@ int bcmgenet_mii_probe(struct net_device *dev) phydev->advertising = phydev->supported; /* The internal PHY has its link interrupts routed to the - * Ethernet MAC ISRs + * Ethernet MAC ISRs. On GENETv5 there is a hardware issue + * that prevents the signaling of link UP interrupts when + * the link operates at 10Mbps, so fallback to polling for + * those versions of GENET. */ - if (priv->internal_phy) + if (priv->internal_phy && !GENET_IS_V5(priv)) dev->phydev->irq = PHY_IGNORE_INTERRUPT; return 0; |