diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2021-09-03 08:42:33 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-09-04 11:52:06 +0200 |
| commit | 7db8263a12155c7ae4ad97e850f1e499c73765fc (patch) | |
| tree | d496b78f437b4333219485835a7b36320929b077 /drivers/net/ethernet/chelsio | |
| parent | qlcnic: Remove redundant unlock in qlcnic_pinit_from_rom (diff) | |
| download | linux-7db8263a12155c7ae4ad97e850f1e499c73765fc.tar.xz linux-7db8263a12155c7ae4ad97e850f1e499c73765fc.zip | |
ethtool: Fix an error code in cxgb2.c
When adapter->registered_device_map is NULL, the value of err is
uncertain, we set err to -EINVAL to avoid ambiguity.
Clean up smatch warning:
drivers/net/ethernet/chelsio/cxgb/cxgb2.c:1114 init_one() warn: missing
error code 'err'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/chelsio')
| -rw-r--r-- | drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c index 73c016166f06..d246eee4b6d5 100644 --- a/drivers/net/ethernet/chelsio/cxgb/cxgb2.c +++ b/drivers/net/ethernet/chelsio/cxgb/cxgb2.c @@ -1111,6 +1111,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) if (!adapter->registered_device_map) { pr_err("%s: could not register any net devices\n", pci_name(pdev)); + err = -EINVAL; goto out_release_adapter_res; } |