diff options
| author | Pavel Skripkin <paskripkin@gmail.com> | 2021-06-18 15:49:02 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-06-18 22:01:17 +0200 |
| commit | 9cca0c2d70149160407bda9a9446ce0c29b6e6c6 (patch) | |
| tree | 2665950cb2d0dc90397cf0c63063a80ef4d2777e /drivers/net/ethernet/ec_bhf.c | |
| parent | Merge tag 'mac80211-for-net-2021-06-18' of git://git.kernel.org/pub/scm/linux... (diff) | |
| download | linux-9cca0c2d70149160407bda9a9446ce0c29b6e6c6.tar.xz linux-9cca0c2d70149160407bda9a9446ce0c29b6e6c6.zip | |
net: ethernet: fix potential use-after-free in ec_bhf_remove
static void ec_bhf_remove(struct pci_dev *dev)
{
...
struct ec_bhf_priv *priv = netdev_priv(net_dev);
unregister_netdev(net_dev);
free_netdev(net_dev);
pci_iounmap(dev, priv->dma_io);
pci_iounmap(dev, priv->io);
...
}
priv is netdev private data, but it is used
after free_netdev(). It can cause use-after-free when accessing priv
pointer. So, fix it by moving free_netdev() after pci_iounmap()
calls.
Fixes: 6af55ff52b02 ("Driver for Beckhoff CX5020 EtherCAT master module.")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/ec_bhf.c')
| -rw-r--r-- | drivers/net/ethernet/ec_bhf.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c index 46b0dbab8aad..7c992172933b 100644 --- a/drivers/net/ethernet/ec_bhf.c +++ b/drivers/net/ethernet/ec_bhf.c @@ -576,10 +576,12 @@ static void ec_bhf_remove(struct pci_dev *dev) struct ec_bhf_priv *priv = netdev_priv(net_dev); unregister_netdev(net_dev); - free_netdev(net_dev); pci_iounmap(dev, priv->dma_io); pci_iounmap(dev, priv->io); + + free_netdev(net_dev); + pci_release_regions(dev); pci_clear_master(dev); pci_disable_device(dev); |