diff options
| author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2020-09-25 19:03:23 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-09-26 02:15:37 +0200 |
| commit | b4f434839e3e269fbd23606a90c1c0cf86039a08 (patch) | |
| tree | 227fc76e88a1131729b25983ebddcc2c9c93be43 /drivers/net/ethernet/freescale | |
| parent | Merge branch 'dpaa2-eth-small-updates' (diff) | |
| download | linux-b4f434839e3e269fbd23606a90c1c0cf86039a08.tar.xz linux-b4f434839e3e269fbd23606a90c1c0cf86039a08.zip | |
dpaa2-mac: Fix potential null pointer dereference
There is a null-check for _pcs_, but it is being dereferenced
prior to this null-check. So, if _pcs_ can actually be null,
then there is a potential null pointer dereference that should
be fixed by null-checking _pcs_ before being dereferenced.
Addresses-Coverity-ID: 1497159 ("Dereference before null check")
Fixes: 94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale')
| -rw-r--r-- | drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c index cdd1acd0117e..90cd243070d7 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c @@ -290,9 +290,9 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac, static void dpaa2_pcs_destroy(struct dpaa2_mac *mac) { struct lynx_pcs *pcs = mac->pcs; - struct device *dev = &pcs->mdio->dev; if (pcs) { + struct device *dev = &pcs->mdio->dev; lynx_pcs_destroy(pcs); put_device(dev); mac->pcs = NULL; |