diff options
| author | Huazhong Tan <tanhuazhong@huawei.com> | 2018-08-23 05:10:12 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-08-23 06:47:36 +0200 |
| commit | b1ccd4c0ab6ef499f47dd84ed4920502a7147bba (patch) | |
| tree | b752241754f95ae42e84511b4cebd3c140a72cdf /drivers/net/ethernet/hisilicon | |
| parent | net: hns: modify variable type in hns_nic_reuse_page (diff) | |
| download | linux-b1ccd4c0ab6ef499f47dd84ed4920502a7147bba.tar.xz linux-b1ccd4c0ab6ef499f47dd84ed4920502a7147bba.zip | |
net: hns: fix skb->truesize underestimation
skb->truesize is not meant to be tracking amount of used bytes in a skb,
but amount of reserved/consumed bytes in memory.
For instance, if we use a single byte in last page fragment, we have to
account the full size of the fragment.
So skb_add_rx_frag needs to calculate the length of the entire buffer into
turesize.
Fixes: 9cbe9fd5214e ("net: hns: optimize XGE capability by reducing cpu usage")
Signed-off-by: Huazhong tan <tanhuazhong@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index c8c0b0309c27..71bd3bff6c67 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c @@ -531,7 +531,7 @@ static void hns_nic_reuse_page(struct sk_buff *skb, int i, } skb_add_rx_frag(skb, i, desc_cb->priv, desc_cb->page_offset + pull_len, - size - pull_len, truesize - pull_len); + size - pull_len, truesize); /* avoid re-using remote pages,flag default unreuse */ if (unlikely(page_to_nid(desc_cb->priv) != numa_node_id())) |