summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/mellanox/mlx4
diff options
context:
space:
mode:
authorToke Høiland-Jørgensen <toke@redhat.com>2021-06-24 18:06:02 +0200
committerDaniel Borkmann <daniel@iogearbox.net>2021-06-24 19:44:58 +0200
commit959ad7ec066d9a61557ad6aedf77ea9b54c82df0 (patch)
tree0da9ffd35cdc989ec544db5f85f357044b78d484 /drivers/net/ethernet/mellanox/mlx4
parentintel: Remove rcu_read_lock() around XDP program invocation (diff)
downloadlinux-959ad7ec066d9a61557ad6aedf77ea9b54c82df0.tar.xz
linux-959ad7ec066d9a61557ad6aedf77ea9b54c82df0.zip
marvell: Remove rcu_read_lock() around XDP program invocation
The mvneta and mvpp2 drivers have rcu_read_lock()/rcu_read_unlock() pairs around XDP program invocations. However, the actual lifetime of the objects referred by the XDP program invocation is longer, all the way through to the call to xdp_do_flush(), making the scope of the rcu_read_lock() too small. This turns out to be harmless because it all happens in a single NAPI poll cycle (and thus under local_bh_disable()), but it makes the rcu_read_lock() misleading. Rather than extend the scope of the rcu_read_lock(), just get rid of it entirely. With the addition of RCU annotations to the XDP_REDIRECT map types that take bh execution into account, lockdep even understands this to be safe, so there's really no reason to keep it around. Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Cc: Russell King <linux@armlinux.org.uk> Cc: Marcin Wojtas <mw@semihalf.com> Link: https://lore.kernel.org/bpf/20210624160609.292325-13-toke@redhat.com
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlx4')
0 files changed, 0 insertions, 0 deletions