diff options
author | Jakub Kicinski <jakub.kicinski@netronome.com> | 2018-06-29 22:09:00 +0200 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2018-06-29 22:09:00 +0200 |
commit | 83235822b8b4fe47ecbd6b6bcbcc902860ac00fc (patch) | |
tree | 19b9db3e4ace53c54a0fbfea6c27dc9dc1248273 /drivers/net/ethernet/micrel | |
parent | PCI/IOV: Reset total_VFs limit after detaching PF driver (diff) | |
download | linux-83235822b8b4fe47ecbd6b6bcbcc902860ac00fc.tar.xz linux-83235822b8b4fe47ecbd6b6bcbcc902860ac00fc.zip |
nfp: stop limiting VFs to 0
Before 8d85a7a4f2c9 ("PCI/IOV: Allow PF drivers to limit total_VFs to 0"),
pci_sriov_set_totalvfs(pdev, 0) meant "we can enable TotalVFs virtual
functions". After 8d85a7a4f2c9, it means "we can't enable *any* VFs".
That broke this scenario where nfp intends to remove any limit on the
number of VFs that can be enabled:
nfp_pci_probe
nfp_pcie_sriov_read_nfd_limit
nfp_rtsym_read_le("nfd_vf_cfg_max_vfs", &err)
pci_sriov_set_totalvfs(pf->pdev, 0) # if FW didn't expose a limit
...
# userspace writes N to sysfs "sriov_numvfs":
sriov_numvfs_store
pci_sriov_get_totalvfs # now returns 0
return -ERANGE
Prior to 8d85a7a4f2c9, pci_sriov_get_totalvfs() returned TotalVFs, but it
now returns 0.
Remove the pci_sriov_set_totalvfs(pdev, 0) calls so we don't limit the
number of VFs that can be enabled.
Fixes: 8d85a7a4f2c9 ("PCI/IOV: Allow PF drivers to limit total_VFs to 0")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
[bhelgaas: changelog]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/net/ethernet/micrel')
0 files changed, 0 insertions, 0 deletions