summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/micrel
diff options
context:
space:
mode:
authorMax.Nekludov@us.elster.com <Max.Nekludov@us.elster.com>2013-03-29 06:27:36 +0100
committerDavid S. Miller <davem@davemloft.net>2013-03-29 20:43:08 +0100
commit14bc435ea54cb888409efb54fc6b76c13ef530e9 (patch)
tree02acc6677f57f6be6a82b4ac794298bc415d3bda /drivers/net/ethernet/micrel
parentnet: add a synchronize_net() in netdev_rx_handler_unregister() (diff)
downloadlinux-14bc435ea54cb888409efb54fc6b76c13ef530e9.tar.xz
linux-14bc435ea54cb888409efb54fc6b76c13ef530e9.zip
ks8851: Fix interpretation of rxlen field.
According to the Datasheet (page 52): 15-12 Reserved 11-0 RXBC Receive Byte Count This field indicates the present received frame byte size. The code has a bug: rxh = ks8851_rdreg32(ks, KS_RXFHSR); rxstat = rxh & 0xffff; rxlen = rxh >> 16; // BUG!!! 0xFFF mask should be applied Signed-off-by: Max Nekludov <Max.Nekludov@us.elster.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/micrel')
-rw-r--r--drivers/net/ethernet/micrel/ks8851.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c
index 33bcb63d56a2..8fb481252e2c 100644
--- a/drivers/net/ethernet/micrel/ks8851.c
+++ b/drivers/net/ethernet/micrel/ks8851.c
@@ -528,7 +528,7 @@ static void ks8851_rx_pkts(struct ks8851_net *ks)
for (; rxfc != 0; rxfc--) {
rxh = ks8851_rdreg32(ks, KS_RXFHSR);
rxstat = rxh & 0xffff;
- rxlen = rxh >> 16;
+ rxlen = (rxh >> 16) & 0xfff;
netif_dbg(ks, rx_status, ks->netdev,
"rx: stat 0x%04x, len 0x%04x\n", rxstat, rxlen);