diff options
| author | Pan Bian <bianpan2016@163.com> | 2016-12-04 06:53:53 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-12-05 20:54:18 +0100 |
| commit | 0ff18d2d36efad65572990fa7febeb3ebe19da89 (patch) | |
| tree | ce7a418232fddd07970d141154170161e2a1d67b /drivers/net/ethernet/qlogic | |
| parent | atm: fix improper return value (diff) | |
| download | linux-0ff18d2d36efad65572990fa7febeb3ebe19da89.tar.xz linux-0ff18d2d36efad65572990fa7febeb3ebe19da89.zip | |
net: ethernet: qlogic: set error code on failure
When calling dma_mapping_error(), the value of return variable rc is 0.
And when the call returns an unexpected value, rc is not set to a
negative errno. Thus, it will return 0 on the error path, and its
callers cannot detect the bug. This patch fixes the bug, assigning
"-ENOMEM" to err.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189041
Signed-off-by: Pan Bian <bianpan2016@163.com>
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qlogic')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qed/qed_ll2.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c index f95385cbbd40..62ae55bd81b8 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c +++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c @@ -1730,6 +1730,7 @@ static int qed_ll2_start_xmit(struct qed_dev *cdev, struct sk_buff *skb) mapping))) { DP_NOTICE(cdev, "Unable to map frag - dropping packet\n"); + rc = -ENOMEM; goto err; } } else { |