diff options
| author | Paul Bolle <pebolle@tiscali.nl> | 2012-11-03 00:53:15 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-11-03 20:43:04 +0100 |
| commit | bb263e18f481199a04f7aab9454c18cd3dbdb218 (patch) | |
| tree | d760742a35d1f0dd35f241e822ea16218690ed85 /drivers/net/ethernet/realtek/atp.h | |
| parent | cpsw: fix leaking IO mappings (diff) | |
| download | linux-bb263e18f481199a04f7aab9454c18cd3dbdb218.tar.xz linux-bb263e18f481199a04f7aab9454c18cd3dbdb218.zip | |
atp: remove set_rx_mode_8012()
Building atp.o triggers this GCC warning:
drivers/net/ethernet/realtek/atp.c: In function ‘set_rx_mode’:
drivers/net/ethernet/realtek/atp.c:871:26: warning: ‘mc_filter[0]’ may be used uninitialized in this function [-Wuninitialized]
GCC is correct. In promiscuous mode 'mc_filter' will be used
uninitialized in set_rx_mode_8012(), which is apparently inlined into
set_rx_mode().
But it turns out set_rx_mode_8012() will never be called, since
net_local.chip_type will always be RTL8002. So we can just remove
set_rx_mode_8012() and do some related cleanups.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/realtek/atp.h')
| -rw-r--r-- | drivers/net/ethernet/realtek/atp.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/realtek/atp.h b/drivers/net/ethernet/realtek/atp.h index 0edc642c2c2f..040b13739947 100644 --- a/drivers/net/ethernet/realtek/atp.h +++ b/drivers/net/ethernet/realtek/atp.h @@ -16,8 +16,6 @@ struct rx_header { #define PAR_STATUS 1 #define PAR_CONTROL 2 -enum chip_type { RTL8002, RTL8012 }; - #define Ctrl_LNibRead 0x08 /* LP_PSELECP */ #define Ctrl_HNibRead 0 #define Ctrl_LNibWrite 0x08 /* LP_PSELECP */ |