diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-06-28 13:44:21 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-06-29 20:19:24 +0200 |
| commit | acb4b7df48b539cb391287921de57e4e5fae3460 (patch) | |
| tree | 597b43a9f7267cf3afad24dd89182f369e925752 /drivers/net/ethernet/rocker | |
| parent | mlxsw: spectrum_router: Fix NULL pointer dereference (diff) | |
| download | linux-acb4b7df48b539cb391287921de57e4e5fae3460.tar.xz linux-acb4b7df48b539cb391287921de57e4e5fae3460.zip | |
rocker: move dereference before free
My static checker complains that ofdpa_neigh_del() can sometimes free
"found". It just makes sense to use it first before deleting it.
Fixes: ecf244f753e0 ("rocker: fix maybe-uninitialized warning")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/rocker')
| -rw-r--r-- | drivers/net/ethernet/rocker/rocker_ofdpa.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c index 2ae852454780..a9ce82d3e9cf 100644 --- a/drivers/net/ethernet/rocker/rocker_ofdpa.c +++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c @@ -1505,8 +1505,8 @@ static int ofdpa_port_ipv4_nh(struct ofdpa_port *ofdpa_port, *index = entry->index; resolved = false; } else if (removing) { - ofdpa_neigh_del(trans, found); *index = found->index; + ofdpa_neigh_del(trans, found); } else if (updating) { ofdpa_neigh_update(found, trans, NULL, false); resolved = !is_zero_ether_addr(found->eth_dst); |