diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 12:56:38 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-09-27 10:03:07 +0200 |
| commit | bd55f8ddbc437c225391ca8f487e7ec10243c4cc (patch) | |
| tree | 9f0477734fb4be4f92b99bdc651902ab3a6f0757 /drivers/net/ethernet/socionext/netsec.c | |
| parent | net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe() (diff) | |
| download | linux-bd55f8ddbc437c225391ca8f487e7ec10243c4cc.tar.xz linux-bd55f8ddbc437c225391ca8f487e7ec10243c4cc.zip | |
net: netsec: Fix signedness bug in netsec_probe()
The "priv->phy_interface" variable is an enum and in this context GCC
will treat it as an unsigned int so the error handling is never
triggered.
Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/socionext/netsec.c')
| -rw-r--r-- | drivers/net/ethernet/socionext/netsec.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c index 1502fe8b0456..55db7fbd43cc 100644 --- a/drivers/net/ethernet/socionext/netsec.c +++ b/drivers/net/ethernet/socionext/netsec.c @@ -2007,7 +2007,7 @@ static int netsec_probe(struct platform_device *pdev) NETIF_MSG_LINK | NETIF_MSG_PROBE; priv->phy_interface = device_get_phy_mode(&pdev->dev); - if (priv->phy_interface < 0) { + if ((int)priv->phy_interface < 0) { dev_err(&pdev->dev, "missing required property 'phy-mode'\n"); ret = -ENODEV; goto free_ndev; |