diff options
author | Grygorii Strashko <grygorii.strashko@ti.com> | 2017-07-29 00:30:04 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-08-02 00:22:55 +0200 |
commit | 0d5f54fec0a18eea5e4ac005646fd2bc2118636c (patch) | |
tree | 6d4a6071695f878692f4cb2db76ff4de8cfc8da1 /drivers/net/ethernet/ti/cpts.h | |
parent | net: ethernet: ti: cpts: convert to use ptp auxiliary worker (diff) | |
download | linux-0d5f54fec0a18eea5e4ac005646fd2bc2118636c.tar.xz linux-0d5f54fec0a18eea5e4ac005646fd2bc2118636c.zip |
net: ethernet: ti: cpts: fix tx timestamping timeout
With the low speed Ethernet connection CPDMA notification about packet
processing can be received before CPTS TX timestamp event, which is set
when packet actually left CPSW while cpdma notification is sent when packet
pushed in CPSW fifo. As result, when connection is slow and CPU is fast
enough TX timestamping is not working properly.
Fix it, by introducing TX SKB queue to store PTP SKBs for which Ethernet
Transmit Event hasn't been received yet and then re-check this queue
with new Ethernet Transmit Events by scheduling CPTS overflow
work more often (every 1 jiffies) until TX SKB queue is not empty.
Side effect of this change is:
- User space tools require to take into account possible delay in TX
timestamp processing (for example ptp4l works with tx_timestamp_timeout=400
under net traffic and tx_timestamp_timeout=25 in idle).
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/ti/cpts.h')
-rw-r--r-- | drivers/net/ethernet/ti/cpts.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/ti/cpts.h b/drivers/net/ethernet/ti/cpts.h index 586edd9c7de0..73d73faf0f38 100644 --- a/drivers/net/ethernet/ti/cpts.h +++ b/drivers/net/ethernet/ti/cpts.h @@ -125,6 +125,7 @@ struct cpts { struct list_head pool; struct cpts_event pool_data[CPTS_MAX_EVENTS]; unsigned long ov_check_period; + struct sk_buff_head txq; }; void cpts_rx_timestamp(struct cpts *cpts, struct sk_buff *skb); |