diff options
| author | Joachim Eastwood <manabian@gmail.com> | 2012-11-16 05:47:15 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-11-20 01:01:18 +0100 |
| commit | c867b55eb4831a493631205f2744b2e77ce0983b (patch) | |
| tree | c8d603edb45c8b7e97ce765f908efa5d60f4d76d /drivers/net/ethernet/wiznet | |
| parent | net: rds: use this_cpu_* per-cpu helper (diff) | |
| download | linux-c867b55eb4831a493631205f2744b2e77ce0983b.tar.xz linux-c867b55eb4831a493631205f2744b2e77ce0983b.zip | |
net/ethernet: remove useless is_valid_ether_addr from drivers ndo_open
If ndo_validate_addr is set to the generic eth_validate_addr
function there is no point in calling is_valid_ether_addr
from driver ndo_open if ndo_open is not used elsewhere in
the driver.
With this change is_valid_ether_addr will be called from the
generic eth_validate_addr function. So there should be no change
in the actual behavior.
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/wiznet')
| -rw-r--r-- | drivers/net/ethernet/wiznet/w5100.c | 2 | ||||
| -rw-r--r-- | drivers/net/ethernet/wiznet/w5300.c | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c index 2c08bf6e7bf3..7daf92e56b65 100644 --- a/drivers/net/ethernet/wiznet/w5100.c +++ b/drivers/net/ethernet/wiznet/w5100.c @@ -580,8 +580,6 @@ static int w5100_open(struct net_device *ndev) struct w5100_priv *priv = netdev_priv(ndev); netif_info(priv, ifup, ndev, "enabling\n"); - if (!is_valid_ether_addr(ndev->dev_addr)) - return -EINVAL; w5100_hw_start(priv); napi_enable(&priv->napi); netif_start_queue(ndev); diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c index 88943d90c765..bd9eec676a58 100644 --- a/drivers/net/ethernet/wiznet/w5300.c +++ b/drivers/net/ethernet/wiznet/w5300.c @@ -500,8 +500,6 @@ static int w5300_open(struct net_device *ndev) struct w5300_priv *priv = netdev_priv(ndev); netif_info(priv, ifup, ndev, "enabling\n"); - if (!is_valid_ether_addr(ndev->dev_addr)) - return -EINVAL; w5300_hw_start(priv); napi_enable(&priv->napi); netif_start_queue(ndev); |