diff options
| author | Igor Russkikh <irusskikh@marvell.com> | 2020-01-06 12:22:29 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-01-06 23:06:11 +0100 |
| commit | 883daa1854b61fe3d21d7d9bf2c81d26a07d586b (patch) | |
| tree | 3ab2d8c73ab5ad28aace4921f3b18c9f23176ad5 /drivers/net/ethernet | |
| parent | net: atlantic: broken link status on old fw (diff) | |
| download | linux-883daa1854b61fe3d21d7d9bf2c81d26a07d586b.tar.xz linux-883daa1854b61fe3d21d7d9bf2c81d26a07d586b.zip | |
net: atlantic: loopback configuration in improper place
Initial loopback configuration should be called earlier, before
starting traffic on HW blocks. Otherwise depending on race conditions
it could be kept disabled.
Fixes: ea4b4d7fc106 ("net: atlantic: loopback tests via private flags")
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index a17a4da7bc15..c85e3e29012c 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -403,6 +403,8 @@ int aq_nic_start(struct aq_nic_s *self) if (err < 0) goto err_exit; + aq_nic_set_loopback(self); + err = self->aq_hw_ops->hw_start(self->aq_hw); if (err < 0) goto err_exit; @@ -413,8 +415,6 @@ int aq_nic_start(struct aq_nic_s *self) INIT_WORK(&self->service_task, aq_nic_service_task); - aq_nic_set_loopback(self); - timer_setup(&self->service_timer, aq_nic_service_timer_cb, 0); aq_nic_service_timer_cb(&self->service_timer); |