diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2019-08-29 04:46:00 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-08-30 23:15:31 +0200 |
| commit | b6b4dc4c1fa7f1c99398e7dc85758049645e9588 (patch) | |
| tree | 0be444946d219364420a89a6b53b62be78a38774 /drivers/net/ethernet | |
| parent | Merge tag 'mac80211-for-davem-2019-08-29' of git://git.kernel.org/pub/scm/lin... (diff) | |
| download | linux-b6b4dc4c1fa7f1c99398e7dc85758049645e9588.tar.xz linux-b6b4dc4c1fa7f1c99398e7dc85758049645e9588.zip | |
amd-xgbe: Fix error path in xgbe_mod_init()
In xgbe_mod_init(), we should do cleanup if some error occurs
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: efbaa828330a ("amd-xgbe: Add support to handle device renaming")
Fixes: 47f164deab22 ("amd-xgbe: Add PCI device support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
| -rw-r--r-- | drivers/net/ethernet/amd/xgbe/xgbe-main.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-main.c b/drivers/net/ethernet/amd/xgbe/xgbe-main.c index b41f23679a08..7ce9c69e9c44 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-main.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-main.c @@ -469,13 +469,19 @@ static int __init xgbe_mod_init(void) ret = xgbe_platform_init(); if (ret) - return ret; + goto err_platform_init; ret = xgbe_pci_init(); if (ret) - return ret; + goto err_pci_init; return 0; + +err_pci_init: + xgbe_platform_exit(); +err_platform_init: + unregister_netdevice_notifier(&xgbe_netdev_notifier); + return ret; } static void __exit xgbe_mod_exit(void) |