diff options
| author | Kumar Gala <galak@kernel.crashing.org> | 2009-04-28 17:04:10 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-04-28 17:04:10 +0200 |
| commit | 6c31d55f755ff2bc1f7dc3b45c500032fe90aff8 (patch) | |
| tree | 8df9753c3f0ab4ebdb332650d11cf5bb5f2260e5 /drivers/net/gianfar.c | |
| parent | inet_diag: Remove dup assignments (diff) | |
| download | linux-6c31d55f755ff2bc1f7dc3b45c500032fe90aff8.tar.xz linux-6c31d55f755ff2bc1f7dc3b45c500032fe90aff8.zip | |
gianfar: Use memset instead of cacheable_memzero
cacheable_memzero() is completely overkill for the clearing out the FCB
block which is only 8-bytes. The compiler should easily optimize this
with memset. Additionally, cacheable_memzero() only exists on ppc32 and
thus breaks builds of gianfar on ppc64.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/gianfar.c')
| -rw-r--r-- | drivers/net/gianfar.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index dae14373296a..2bb038b98cc4 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1207,7 +1207,8 @@ static int gfar_enet_open(struct net_device *dev) static inline struct txfcb *gfar_add_fcb(struct sk_buff *skb) { struct txfcb *fcb = (struct txfcb *)skb_push(skb, GMAC_FCB_LEN); - cacheable_memzero(fcb, GMAC_FCB_LEN); + + memset(fcb, 0, GMAC_FCB_LEN); return fcb; } |