summaryrefslogtreecommitdiffstats
path: root/drivers/net/gianfar.c
diff options
context:
space:
mode:
authorKumar Gala <galak@kernel.crashing.org>2007-06-29 07:12:04 +0200
committerKumar Gala <galak@kernel.crashing.org>2007-06-29 07:12:04 +0200
commit8da32de5c845b711a500f89342baf10c662e2ecb (patch)
tree51771f5db24832907e4fcde627d21dc81e4b07bf /drivers/net/gianfar.c
parentMerge branch 'for_linus' of master.kernel.org:/pub/scm/linux/kernel/git/galak... (diff)
downloadlinux-8da32de5c845b711a500f89342baf10c662e2ecb.tar.xz
linux-8da32de5c845b711a500f89342baf10c662e2ecb.zip
gianfar: Fix typo bug introduced by move to udp_hdr()
In commit 4bedb45203eab92a87b4c863fe2d0cded633427f both the udp and tcp cases where changed to use udp_hdr() instead of leaving the tcp case alone and fixing with tcp_hdr(). This ended up causing random behavior with TCP connections because of looking for tcp_hdr()->check in the wrong place. Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Diffstat (limited to 'drivers/net/gianfar.c')
-rw-r--r--drivers/net/gianfar.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
index 6822bf14267b..1b854bf07b09 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c
@@ -944,7 +944,7 @@ static inline void gfar_tx_checksum(struct sk_buff *skb, struct txfcb *fcb)
flags |= TXFCB_UDP;
fcb->phcs = udp_hdr(skb)->check;
} else
- fcb->phcs = udp_hdr(skb)->check;
+ fcb->phcs = tcp_hdr(skb)->check;
/* l3os is the distance between the start of the
* frame (skb->data) and the start of the IP hdr.