diff options
author | Edward Cree <ecree.xilinx@gmail.com> | 2023-08-21 20:01:53 +0200 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-08-22 20:09:53 +0200 |
commit | 6dc5774deefe38d9ab385a5dafbe6614ae63d166 (patch) | |
tree | d9615f7aef6ad6816c9cd6d6cf346e2ea8646f3c /drivers/net/hippi | |
parent | Merge tag 'wireless-2023-08-22' of git://git.kernel.org/pub/scm/linux/kernel/... (diff) | |
download | linux-6dc5774deefe38d9ab385a5dafbe6614ae63d166.tar.xz linux-6dc5774deefe38d9ab385a5dafbe6614ae63d166.zip |
sfc: allocate a big enough SKB for loopback selftest packet
Cited commits passed a size to alloc_skb that was only big enough for
the actual packet contents, but the following skb_put + memcpy writes
the whole struct efx_loopback_payload including leading and trailing
padding bytes (which are then stripped off with skb_pull/skb_trim).
This could cause an skb_over_panic, although in practice we get saved
by kmalloc_size_roundup.
Pass the entire size we use, instead of the size of the final packet.
Reported-by: Andy Moreton <andy.moreton@amd.com>
Fixes: cf60ed469629 ("sfc: use padding to fix alignment in loopback test")
Fixes: 30c24dd87f3f ("sfc: siena: use padding to fix alignment in loopback test")
Fixes: 1186c6b31ee1 ("sfc: falcon: use padding to fix alignment in loopback test")
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20230821180153.18652-1-edward.cree@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/hippi')
0 files changed, 0 insertions, 0 deletions