summaryrefslogtreecommitdiffstats
path: root/drivers/net/ieee802154
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2019-09-19 14:12:34 +0200
committerStefan Schmidt <stefan@datenfreihafen.org>2019-09-19 16:17:57 +0200
commit7fd25e6fc035f4b04b75bca6d7e8daa069603a76 (patch)
treede38167115834700c8622e7ec512d90f3c6174fb /drivers/net/ieee802154
parentr8152: Set memory to all 0xFFs on failed reg reads (diff)
downloadlinux-7fd25e6fc035f4b04b75bca6d7e8daa069603a76.tar.xz
linux-7fd25e6fc035f4b04b75bca6d7e8daa069603a76.zip
ieee802154: atusb: fix use-after-free at disconnect
The disconnect callback was accessing the hardware-descriptor private data after having having freed it. Fixes: 7490b008d123 ("ieee802154: add support for atusb transceiver") Cc: stable <stable@vger.kernel.org> # 4.2 Cc: Alexander Aring <alex.aring@gmail.com> Reported-by: syzbot+f4509a9138a1472e7e80@syzkaller.appspotmail.com Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Diffstat (limited to 'drivers/net/ieee802154')
-rw-r--r--drivers/net/ieee802154/atusb.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index ceddb424f887..0dd0ba915ab9 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -1137,10 +1137,11 @@ static void atusb_disconnect(struct usb_interface *interface)
ieee802154_unregister_hw(atusb->hw);
+ usb_put_dev(atusb->usb_dev);
+
ieee802154_free_hw(atusb->hw);
usb_set_intfdata(interface, NULL);
- usb_put_dev(atusb->usb_dev);
pr_debug("%s done\n", __func__);
}