diff options
| author | Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-09-18 00:47:12 +0200 |
|---|---|---|
| committer | Stefan Schmidt <stefan@datenfreihafen.org> | 2019-09-27 21:57:42 +0200 |
| commit | 6402939ec86eaf226c8b8ae00ed983936b164908 (patch) | |
| tree | 7803cfd97b141bda44913009e5342a8d29547033 /drivers/net/ieee802154 | |
| parent | ieee802154: mcr20a: simplify a bit 'mcr20a_handle_rx_read_buf_complete()' (diff) | |
| download | linux-6402939ec86eaf226c8b8ae00ed983936b164908.tar.xz linux-6402939ec86eaf226c8b8ae00ed983936b164908.zip | |
ieee802154: ca8210: prevent memory leak
In ca8210_probe the allocated pdata needs to be assigned to
spi_device->dev.platform_data before calling ca8210_get_platform_data.
Othrwise when ca8210_get_platform_data fails pdata cannot be released.
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Link: https://lore.kernel.org/r/20190917224713.26371-1-navid.emamdoost@gmail.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Diffstat (limited to 'drivers/net/ieee802154')
| -rw-r--r-- | drivers/net/ieee802154/ca8210.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index b188fce3f641..658b399ac9ea 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -3152,12 +3152,12 @@ static int ca8210_probe(struct spi_device *spi_device) goto error; } + priv->spi->dev.platform_data = pdata; ret = ca8210_get_platform_data(priv->spi, pdata); if (ret) { dev_crit(&spi_device->dev, "ca8210_get_platform_data failed\n"); goto error; } - priv->spi->dev.platform_data = pdata; ret = ca8210_dev_com_init(priv); if (ret) { |