summaryrefslogtreecommitdiffstats
path: root/drivers/net/ipa
diff options
context:
space:
mode:
authorAlex Elder <elder@linaro.org>2021-02-04 02:06:55 +0100
committerJakub Kicinski <kuba@kernel.org>2021-02-05 03:55:54 +0100
commit1d23a56b0296d29e7047b41fe0a42a001036160d (patch)
treed048bdfbb70ec2a28c43da8f342550d9b9cf4e2b /drivers/net/ipa
parentnet: hdlc_x25: Return meaningful error code in x25_open (diff)
downloadlinux-1d23a56b0296d29e7047b41fe0a42a001036160d.tar.xz
linux-1d23a56b0296d29e7047b41fe0a42a001036160d.zip
net: ipa: set error code in gsi_channel_setup()
In gsi_channel_setup(), we check to see if the configuration data contains any information about channels that are not supported by the hardware. If one is found, we abort the setup process, but the error code (ret) is not set in this case. Fix this bug. Fixes: 650d1603825d8 ("soc: qcom: ipa: the generic software interface") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Alex Elder <elder@linaro.org> Link: https://lore.kernel.org/r/20210204010655.15619-1-elder@linaro.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ipa')
-rw-r--r--drivers/net/ipa/gsi.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index 34e5f2155d62..b77f5fef7aec 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -1710,6 +1710,7 @@ static int gsi_channel_setup(struct gsi *gsi)
if (!channel->gsi)
continue; /* Ignore uninitialized channels */
+ ret = -EINVAL;
dev_err(gsi->dev, "channel %u not supported by hardware\n",
channel_id - 1);
channel_id = gsi->channel_count;