summaryrefslogtreecommitdiffstats
path: root/drivers/net/ksz884x.c
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2010-04-13 06:59:44 +0200
committerDavid S. Miller <davem@davemloft.net>2010-04-14 13:52:03 +0200
commit0110d6f22f392f976e84ab49da1b42f85b64a3c5 (patch)
tree6894f343f66337babdb5615c5a384c49396ade20 /drivers/net/ksz884x.c
parentforcedeth: fix tx limit2 flag check (diff)
downloadlinux-0110d6f22f392f976e84ab49da1b42f85b64a3c5.tar.xz
linux-0110d6f22f392f976e84ab49da1b42f85b64a3c5.zip
tun: orphan an skb on tx
The following situation was observed in the field: tap1 sends packets, tap2 does not consume them, as a result tap1 can not be closed. This happens because tun/tap devices can hang on to skbs undefinitely. As noted by Herbert, possible solutions include a timeout followed by a copy/change of ownership of the skb, or always copying/changing ownership if we're going into a hostile device. This patch implements the second approach. Note: one issue still remaining is that since skbs keep reference to tun socket and tun socket has a reference to tun device, we won't flush backlog, instead simply waiting for all skbs to get transmitted. At least this is not user-triggerable, and this was not reported in practice, my assumption is other devices besides tap complete an skb within finite time after it has been queued. A possible solution for the second issue would not to have socket reference the device, instead, implement dev->destructor for tun, and wait for all skbs to complete there, but this needs some thought, probably too risky for 2.6.34. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Tested-by: Yan Vugenfirer <yvugenfi@redhat.com> Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ksz884x.c')
0 files changed, 0 insertions, 0 deletions