diff options
| author | Alexander Duyck <alexander.h.duyck@intel.com> | 2017-10-13 22:40:24 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-10-15 03:46:36 +0200 |
| commit | dd6b9c2c332b40f142740d1b11fb77c653ff98ea (patch) | |
| tree | 015ec7d8642ea8fa811f42c469dc193ca70dd510 /drivers/net/macvlan.c | |
| parent | tcp: add a tracepoint for tcp retransmission (diff) | |
| download | linux-dd6b9c2c332b40f142740d1b11fb77c653ff98ea.tar.xz linux-dd6b9c2c332b40f142740d1b11fb77c653ff98ea.zip | |
macvlan: Only deliver one copy of the frame to the macvlan interface
This patch intoduces a slight adjustment for macvlan to address the fact
that in source mode I was seeing two copies of any packet addressed to the
macvlan interface being delivered where there should have been only one.
The issue appears to be that one copy was delivered based on the source MAC
address and then the second copy was being delivered based on the
destination MAC address. To fix it I am just treating a unicast address
match as though it is not a match since source based macvlan isn't supposed
to be matching based on the destination MAC anyway.
Fixes: 79cf79abce71 ("macvlan: add source mode")
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/macvlan.c')
| -rw-r--r-- | drivers/net/macvlan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 858bd66511a2..a4ae8cd0f660 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -480,7 +480,7 @@ static rx_handler_result_t macvlan_handle_frame(struct sk_buff **pskb) struct macvlan_dev, list); else vlan = macvlan_hash_lookup(port, eth->h_dest); - if (vlan == NULL) + if (!vlan || vlan->mode == MACVLAN_MODE_SOURCE) return RX_HANDLER_PASS; dev = vlan->dev; |