diff options
| author | roel kluin <roel.kluin@gmail.com> | 2009-08-09 01:54:21 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-08-10 06:47:01 +0200 |
| commit | 973507cb8610d4c84f090d5f1f0ca54fa0559d27 (patch) | |
| tree | 5d372cd2c7263065ccf318cc62ff01ddda0d0226 /drivers/net/mlx4 | |
| parent | zorro8390: Fix read buffer overflow in zorro8390_init_one() (diff) | |
| download | linux-973507cb8610d4c84f090d5f1f0ca54fa0559d27.tar.xz linux-973507cb8610d4c84f090d5f1f0ca54fa0559d27.zip | |
mlx4_en: Fix read buffer overflow in mlx4_en_complete_rx_desc()
If the length is less or equal to frag_prefix_size in the first iteration
we write skb_frags_rx[-1] and read from priv->frag_info[-1]
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/mlx4')
| -rw-r--r-- | drivers/net/mlx4/en_rx.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/net/mlx4/en_rx.c b/drivers/net/mlx4/en_rx.c index 91bdfdfd431f..3ac0404d0d11 100644 --- a/drivers/net/mlx4/en_rx.c +++ b/drivers/net/mlx4/en_rx.c @@ -506,8 +506,9 @@ static int mlx4_en_complete_rx_desc(struct mlx4_en_priv *priv, PCI_DMA_FROMDEVICE); } /* Adjust size of last fragment to match actual length */ - skb_frags_rx[nr - 1].size = length - - priv->frag_info[nr - 1].frag_prefix_size; + if (nr > 0) + skb_frags_rx[nr - 1].size = length - + priv->frag_info[nr - 1].frag_prefix_size; return nr; fail: |