summaryrefslogtreecommitdiffstats
path: root/drivers/net/mv643xx_eth.c
diff options
context:
space:
mode:
authorJarek Poplawski <jarkao2@gmail.com>2008-09-30 22:58:25 +0200
committerDavid S. Miller <davem@davemloft.net>2008-10-09 01:56:48 +0200
commitf47aeffd6089ed7a0cd18073e88cd505f188b0b7 (patch)
tree5020fbc523db172782cc873da178f6cfd78d06d6 /drivers/net/mv643xx_eth.c
parentixgb: fix bug when freeing resources (diff)
downloadlinux-f47aeffd6089ed7a0cd18073e88cd505f188b0b7.tar.xz
linux-f47aeffd6089ed7a0cd18073e88cd505f188b0b7.zip
lib8390: Fix locking in ei_poll (poll controller)
This lockdep warning: ================================= [ INFO: inconsistent lock state ] 2.6.27-rc7 #3 --------------------------------- inconsistent {in-softirq-W} -> {softirq-on-W} usage. syslogd/2474 [HC0[0]:SC0[0]:HE1:SE1] takes: (_xmit_ETHER#2){-+..}, at: [<c0265562>] netpoll_send_skb+0x132/0x190 ... is caused by unconditional local_irq_disable()/local_irq_enable() in disable_irq_lockdep()/enable_irq_lockdep() used by __ei_poll(). Since netconsole/netpoll always calls dev->poll_controller() with local irqs disabled, disable_irq()/enable_irq() instead is safe and enough (like e.g. in 3c509 or 8139xx drivers). Reported-and-tested-by: Bernard Pidoux F6BVP <f6bvp@free.fr> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/mv643xx_eth.c')
0 files changed, 0 insertions, 0 deletions