diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-27 10:34:25 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-27 22:45:14 +0200 |
| commit | 0df125d05d19ea71678842289647f35cec6d3314 (patch) | |
| tree | 85f6478d1e314fcf4699730e15e738bdfb3d9f7c /drivers/net/phy/marvell.c | |
| parent | net: nvidia: forcedeth: Replace GFP_ATOMIC with GFP_KERNEL in nv_probe() (diff) | |
| download | linux-0df125d05d19ea71678842289647f35cec6d3314.tar.xz linux-0df125d05d19ea71678842289647f35cec6d3314.zip | |
net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init()
m88e1116r_config_init() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/marvell.c')
| -rw-r--r-- | drivers/net/phy/marvell.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 1cd439bdf608..f7c69ca34056 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -679,7 +679,7 @@ static int m88e1116r_config_init(struct phy_device *phydev) if (err < 0) return err; - mdelay(500); + msleep(500); err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); if (err < 0) |