diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2017-03-05 21:34:49 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-03-06 02:57:27 +0100 |
| commit | 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 (patch) | |
| tree | 5e5a0765be73afca26e683014671e4b884d9695a /drivers/net/phy/phy_device.c | |
| parent | bpf: add get_next_key callback to LPM map (diff) | |
| download | linux-0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6.tar.xz linux-0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6.zip | |
net: phy: Do not perform software reset for Generic PHY
The Generic PHY driver is a catch-all PHY driver and it should preserve
whatever prior initialization has been done by boot loader or firmware
agents. For specific PHY device configuration it is expected that a
specialized PHY driver would take over that role.
Resetting the generic PHY was a bad idea that has lead to several
complaints and downstream workarounds e.g: in OpenWrt/LEDE so restore
the behavior prior to 87aa9f9c61ad ("net: phy: consolidate PHY
reset in phy_init_hw()").
Reported-by: Felix Fietkau <nbd@nbd.name>
Fixes: 87aa9f9c61ad ("net: phy: consolidate PHY reset in phy_init_hw()")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phy_device.c')
| -rw-r--r-- | drivers/net/phy/phy_device.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index daec6555f3b1..5198ccfa347f 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1864,7 +1864,7 @@ static struct phy_driver genphy_driver[] = { .phy_id = 0xffffffff, .phy_id_mask = 0xffffffff, .name = "Generic PHY", - .soft_reset = genphy_soft_reset, + .soft_reset = genphy_no_soft_reset, .config_init = genphy_config_init, .features = PHY_GBIT_FEATURES | SUPPORTED_MII | SUPPORTED_AUI | SUPPORTED_FIBRE | |