diff options
| author | Mark Brown <broonie@kernel.org> | 2016-04-20 13:54:05 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-04-21 21:00:27 +0200 |
| commit | a1459c1c9ebcd72f3d488fd10673e64b2bfcbd27 (patch) | |
| tree | c645f5835979c2f6e612a392762bc58decb2a921 /drivers/net/phy | |
| parent | net: ethernet: davinci_emac: Fix platform_data overwrite (diff) | |
| download | linux-a1459c1c9ebcd72f3d488fd10673e64b2bfcbd27.tar.xz linux-a1459c1c9ebcd72f3d488fd10673e64b2bfcbd27.zip | |
net: phy: spi_ks8895: Don't leak references to SPI devices
The ks8895 driver is using spi_dev_get() apparently just to take a copy
of the SPI device used to instantiate it but never calls spi_dev_put()
to free it. Since the device is guaranteed to exist between probe() and
remove() there should be no need for the driver to take an extra
reference to it so fix the leak by just using a straight assignment.
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy')
| -rw-r--r-- | drivers/net/phy/spi_ks8995.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index b5d50d458728..93ffedfa2994 100644 --- a/drivers/net/phy/spi_ks8995.c +++ b/drivers/net/phy/spi_ks8995.c @@ -441,7 +441,7 @@ static int ks8995_probe(struct spi_device *spi) return -ENOMEM; mutex_init(&ks->lock); - ks->spi = spi_dev_get(spi); + ks->spi = spi; ks->chip = &ks8995_chip[variant]; if (ks->spi->dev.of_node) { |