summaryrefslogtreecommitdiffstats
path: root/drivers/net/ppp/ppp_mppe.c
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2017-06-05 14:22:50 +0200
committerDavid S. Miller <davem@davemloft.net>2017-06-06 21:16:33 +0200
commit4f5a98410d29bf87f587b19f5ae4e244b1ed4e18 (patch)
treec0f61216a28a46815015a5956c88d11922db98ba /drivers/net/ppp/ppp_mppe.c
parentnet: phy: Delete unused function phy_ethtool_gset (diff)
downloadlinux-4f5a98410d29bf87f587b19f5ae4e244b1ed4e18.tar.xz
linux-4f5a98410d29bf87f587b19f5ae4e244b1ed4e18.zip
ppp: mppe: Use vsnprintf extension %phN
Using this extension reduces the object size. $ size drivers/net/ppp/ppp_mppe.o* text data bss dec hex filename 5683 216 8 5907 1713 drivers/net/ppp/ppp_mppe.o.new 5808 216 8 6032 1790 drivers/net/ppp/ppp_mppe.o.old Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ppp/ppp_mppe.c')
-rw-r--r--drivers/net/ppp/ppp_mppe.c15
1 files changed, 4 insertions, 11 deletions
diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
index f60f7660b451..6c7fd98cb00a 100644
--- a/drivers/net/ppp/ppp_mppe.c
+++ b/drivers/net/ppp/ppp_mppe.c
@@ -298,21 +298,14 @@ mppe_init(void *arg, unsigned char *options, int optlen, int unit, int debug,
mppe_rekey(state, 1);
if (debug) {
- int i;
- char mkey[sizeof(state->master_key) * 2 + 1];
- char skey[sizeof(state->session_key) * 2 + 1];
-
printk(KERN_DEBUG "%s[%d]: initialized with %d-bit %s mode\n",
debugstr, unit, (state->keylen == 16) ? 128 : 40,
(state->stateful) ? "stateful" : "stateless");
-
- for (i = 0; i < sizeof(state->master_key); i++)
- sprintf(mkey + i * 2, "%02x", state->master_key[i]);
- for (i = 0; i < sizeof(state->session_key); i++)
- sprintf(skey + i * 2, "%02x", state->session_key[i]);
printk(KERN_DEBUG
- "%s[%d]: keys: master: %s initial session: %s\n",
- debugstr, unit, mkey, skey);
+ "%s[%d]: keys: master: %*phN initial session: %*phN\n",
+ debugstr, unit,
+ (int)sizeof(state->master_key), state->master_key,
+ (int)sizeof(state->session_key), state->session_key);
}
/*