diff options
| author | Ben Hutchings <bhutchings@solarflare.com> | 2009-11-23 17:03:45 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-11-24 19:58:39 +0100 |
| commit | 398468ed1b5c61fe8bcbc8cc1ed323e3c23b58ef (patch) | |
| tree | 2c9f8932143b91d8affe388bd21d98beab7c7488 /drivers/net/sfc/qt202x_phy.c | |
| parent | sfc: SFT9001: Reset LED configuration correctly after blinking (diff) | |
| download | linux-398468ed1b5c61fe8bcbc8cc1ed323e3c23b58ef.tar.xz linux-398468ed1b5c61fe8bcbc8cc1ed323e3c23b58ef.zip | |
sfc: Use a single blink implementation
Only some PHYs have firmware support for a LED blink mode, so we
currently blink the others in a timer function. Since all PHYs have
simple on and off modes, we don't gain anything by using multiple
blink implementations. Also, since we have a process context there
is no need to use a timer.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sfc/qt202x_phy.c')
| -rw-r--r-- | drivers/net/sfc/qt202x_phy.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/sfc/qt202x_phy.c b/drivers/net/sfc/qt202x_phy.c index 560eb18280e1..05c0f9acedbd 100644 --- a/drivers/net/sfc/qt202x_phy.c +++ b/drivers/net/sfc/qt202x_phy.c @@ -228,9 +228,6 @@ static void qt202x_phy_get_settings(struct efx_nic *efx, struct ethtool_cmd *ecm static void qt202x_phy_fini(struct efx_nic *efx) { - /* Clobber the LED if it was blinking */ - efx->board_info.blink(efx, false); - /* Free the context block */ kfree(efx->phy_data); efx->phy_data = NULL; |