diff options
| author | Ben Hutchings <bhutchings@solarflare.com> | 2010-06-30 04:44:32 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-06-30 23:09:35 +0200 |
| commit | 1437ce3983bcbc0447a0dedcd644c14fe833d266 (patch) | |
| tree | 073ba0dc60127b08b65fbcca4d0d7c15318c08f8 /drivers/net/sfc | |
| parent | cxgb4vf: Use correct shift factor for extracting the SGE DMA Ingress Padding ... (diff) | |
| download | linux-1437ce3983bcbc0447a0dedcd644c14fe833d266.tar.xz linux-1437ce3983bcbc0447a0dedcd644c14fe833d266.zip | |
ethtool: Change ethtool_op_set_flags to validate flags
ethtool_op_set_flags() does not check for unsupported flags, and has
no way of doing so. This means it is not suitable for use as a
default implementation of ethtool_ops::set_flags.
Add a 'supported' parameter specifying the flags that the driver and
hardware support, validate the requested flags against this, and
change all current callers to pass this parameter.
Change some other trivial implementations of ethtool_ops::set_flags to
call ethtool_op_set_flags().
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Reviewed-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sfc')
| -rw-r--r-- | drivers/net/sfc/ethtool.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/sfc/ethtool.c b/drivers/net/sfc/ethtool.c index 7693cfbf9cf4..23372bf5cd59 100644 --- a/drivers/net/sfc/ethtool.c +++ b/drivers/net/sfc/ethtool.c @@ -551,10 +551,7 @@ static int efx_ethtool_set_flags(struct net_device *net_dev, u32 data) struct efx_nic *efx = netdev_priv(net_dev); u32 supported = efx->type->offload_features & ETH_FLAG_RXHASH; - if (data & ~supported) - return -EOPNOTSUPP; - - return ethtool_op_set_flags(net_dev, data); + return ethtool_op_set_flags(net_dev, data, supported); } static void efx_ethtool_self_test(struct net_device *net_dev, |